RFR: 8377338: URLJarFile$URLJarFileEntry need not clone the arrays returned by getCertificates() and getCodeSigners()

Jaikiran Pai jpai at openjdk.org
Fri Feb 6 10:10:47 UTC 2026


Can I please get a review of this change which removes the overriden `getCertificates()` and `getCodeSigners()` method implementations in `URLJarFile$URLJarFileEntry`?

These overriden implementations were returning a cloned array, but as noted in https://bugs.openjdk.org/browse/JDK-8377338, these overrides are not needed because the corresponding methods in the `JarEntry` super class already return a cloned array.

Existing tests in tier1, tier2 and tier3 continue to pass with this change.

-------------

Commit messages:
 - URLJarFile$URLJarFileEntry need not clone the arrays returned by getCertificates() and getCodeSigners()

Changes: https://git.openjdk.org/jdk/pull/29600/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29600&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8377338
  Stats: 14 lines in 1 file changed: 1 ins; 12 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/29600.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29600/head:pull/29600

PR: https://git.openjdk.org/jdk/pull/29600


More information about the net-dev mailing list