RFR: 8377675: java.net.http tests should not depend on ../../../com/sun/net/httpserver test classes [v5]

Daniel Fuchs dfuchs at openjdk.org
Fri Feb 13 13:15:01 UTC 2026


> Some HttpClient tests - like `test/jdk/java/net/httpclient/SmokeTest.java`, depend on non-library test classes that were developed for testing the HttpServer, such as `../../../com/sun/net/httpserver/FileServerHandler.java` which requires compiling using `@compile`.
> 
> Instead of depending on HttpServer test classes, these tests should use functionalities from the common servers provided by the `HttpServerAdapters`, offered by the `test/jdk/java/net/httpclient/lib` library. An adapted version of the `../../../com/sun/net/httpserver/FileServerHandler.java` could be provided by the `HttpServerAdapters` helper.
> 
> There are also 5 implementations of stand-alone echo handlers in the httpclient test base. This change remove 4 of them, keep only the implementation in `HttpServerAdapters`, and updates all tests that were relying on the removed implementations to use that provided by `HttpServerAdapters`.
> 
> This is a test-only change.

Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:

 - Merge branch 'master' into sanitize-echo-handlers-8377675
 - Review feedback: removed HttpTestExchange.chunkedRsp(long)
 - Update test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
   
   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
 - Update test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
   
   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
 - Update test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
   
   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
 - Update test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
   
   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
 - Update test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
   
   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
 - Update test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
   
   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
 - Update test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
   
   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
 - Update test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java
   
   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
 - ... and 4 more: https://git.openjdk.org/jdk/compare/017dc08c...71f9ea91

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/29702/files
  - new: https://git.openjdk.org/jdk/pull/29702/files/fae5304b..71f9ea91

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=29702&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29702&range=03-04

  Stats: 1748 lines in 86 files changed: 991 ins; 342 del; 415 mod
  Patch: https://git.openjdk.org/jdk/pull/29702.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29702/head:pull/29702

PR: https://git.openjdk.org/jdk/pull/29702


More information about the net-dev mailing list