RFR: 8377302: HttpServer::stop uses full timeout duration if handler throws [v2]
Daniel Fuchs
dfuchs at openjdk.org
Mon Feb 16 11:00:28 UTC 2026
On Wed, 11 Feb 2026 09:01:36 GMT, Michael McMahon <michaelm at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update test/jdk/com/sun/net/httpserver/FailAndStopTest.java
>>
>> Co-authored-by: Volkan Yazıcı <volkan.yazici at oracle.com>
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java line 91:
>
>> 89:
>> 90: private final AtomicBoolean ended = new AtomicBoolean();
>> 91: private final AtomicBoolean finished = new AtomicBoolean();
>
> Maybe my previous concern would be allayed if we add comments explaining the meaning of these fields.
I have added comments. Do they allay your concerns @Michael-Mc-Mahon ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29606#discussion_r2811827877
More information about the net-dev
mailing list