RFR: 8378163: test/jdk/java/net/httpclient/*.java: convert tests that use ITestContext to JUnit [v3]

[Daniel Fuchs]

On Fri, 20 Feb 2026 13:48:27 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into ITestContext-httpclient-8378163
>>  - Remove Lifecycle.PER_CLASS
>>  - Merge branch 'master' into ITestContext-httpclient-8378163
>>  - 8378163: test/jdk/java/net/httpclient/*.java: convert tests that use ITestContext to JUnit
>
> @dfuch, I've skimmed over the changes (it was big!) and could not see any red flags. I'm assuming Tier 1-2 is clear. Thanks so much for taking care of this work.

Thank you for the review @vy.

> test/jdk/java/net/httpclient/AggregateRequestBodyTest.java line 159:
> 
>> 157:     }
>> 158: 
>> 159:     static final class TestStopper implements TestWatcher, BeforeEachCallback {
> 
> We shouldn't be copy-pasting such a basic(?) JUnit operator. I will check following options in preference order:
> 
> 1. Does JUnit provide a feature to _"stop after failure"_?
> 2. If not, could JUnit maintainers add such a feature? (We can also contribute this, granted they approve the design.)
> 3. If not, add this to `/test/lib`.

It's not worse than the previous boiler plate. It's in fact much better. It was suggested by @sormuras .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29786#issuecomment-3934957590
PR Review Comment: https://git.openjdk.org/jdk/pull/29786#discussion_r2833332896