RFR: 8378164: test/jdk/java/net/httpclient/http3/*.java: convert tests that use ITestContext to JUnit [v2]
Andrey Turbanov
aturbanov at openjdk.org
Fri Feb 20 20:26:48 UTC 2026
On Fri, 20 Feb 2026 11:10:52 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Similar to https://github.com/openjdk/jdk/pull/29786 - this time with HTTP/3 tests.
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into ITestContext-http3-8378164
> - 8378164: test/jdk/java/net/httpclient/http3/*.java: convert tests that use ITestContext to JUnit
test/jdk/java/net/httpclient/http3/GetHTTP3Test.java line 339:
> 337: out.println("Response is: " + response + ", [version: " + response.version() + "]");
> 338: assertEquals(200, response.statusCode(),"status for " + u);
> 339: assertEquals(BODY, response.body(),"body for " + u);
Suggestion:
assertEquals(200, response.statusCode(), "status for " + u);
assertEquals(BODY, response.body(), "body for " + u);
test/jdk/java/net/httpclient/http3/PostHTTP3Test.java line 367:
> 365: out.println("Response is: " + response + ", [version: " + response.version() + "]");
> 366: assertEquals(200, response.statusCode(),"status for " + u);
> 367: assertEquals(BODY, response.body(),"body for " + u);
Suggestion:
assertEquals(200, response.statusCode(), "status for " + u);
assertEquals(BODY, response.body(), "body for " + u);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29824#discussion_r2834967239
PR Review Comment: https://git.openjdk.org/jdk/pull/29824#discussion_r2834968240
More information about the net-dev
mailing list