RFR: 8378344: Refactor test/jdk/java/net/httpclient/*.java TestNG tests to JUnit [v3]
Daniel Fuchs
dfuchs at openjdk.org
Tue Feb 24 12:04:26 UTC 2026
On Tue, 24 Feb 2026 08:14:02 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review feedback: introduce actual/expected
>
> test/jdk/java/net/httpclient/CookieHeaderTest.java line 177:
>
>> 175: assertEquals( cookies.stream()
>> 176: .filter(s -> !s.startsWith("LOC"))
>> 177: .collect(Collectors.toList()), response.headers().allValues("X-Request-Cookie"));
>
> There is a syntax issue. Putting that aside, it might be better to create two `{expected,actual}Cookies` variables to decrease the cognitive load here.
Thanks. Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29850#discussion_r2846578993
More information about the net-dev
mailing list