RFR: 8374432: TimeoutResponseBodyTest.java#retriesEnabledForResponseFailure fails run with -Xcomp [v2]
SendaoYan
syan at openjdk.org
Sat Jan 3 02:08:24 UTC 2026
On Wed, 31 Dec 2025 11:04:27 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> use "jdk.test.lib.Utils.adjustTimeout"
>
> test/jdk/java/net/httpclient/TimeoutResponseTestSupport.java line 81:
>
>> 79: protected static final Duration REQUEST_TIMEOUT =
>> 80: Duration.ofMillis(Long.parseLong(System.getProperty("test.requestTimeoutMillis"))
>> 81: * timeoutFactor);
>
> Can we use `jdk.test.lib.Utils::adjustTimeout` instead of manually reading and applying the `test.timeout.factor` system property?
Thanks for the advice.
Since jdk.test.lib.Utils has some duplicate element name to jdk.internal.net.http.common.Utils, So I use the fully qualified name of jdk.test.lib.Utils.adjustTimeout.
> test/jdk/java/net/httpclient/TimeoutResponseTestSupport.java line 111:
>
>> 109: .ofMillis(RESPONSE_FAILURE_WAIT_DURATION_MILLIS)
>> 110: .multipliedBy(RETRY_LIMIT)
>> 111: .multipliedBy(timeoutFactor);
>
> Similar to what we do with `REQUEST_TIMEOUT`, can we instead use `adjustTimeout` while initializing the `RESPONSE_FAILURE_WAIT_DURATION_MILLIS`?
Same as above. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29012#discussion_r2658647452
PR Review Comment: https://git.openjdk.org/jdk/pull/29012#discussion_r2658647576
More information about the net-dev
mailing list