RFR: 8376118: java/net/httpclient/StreamingBody.java fails intermittently on Windows [v2]

Daniel Fuchs dfuchs at openjdk.org
Fri Jan 23 10:23:07 UTC 2026


On Fri, 23 Jan 2026 09:50:46 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

> In `newRequestBuilder`, I see we explicitly set the version (along with the discovery flag) only for HTTP/3. Shouldn't we ideally be doing this for all versions to ensure that, say, the HTTP/2 test indeed uses HTTP/2?

The default version is HTTP/2 so there's no need to set the version at the request level if the version is not HTTP/3. HTTP/3 is the only version that requires an opt-in.

> test/jdk/java/net/httpclient/StreamingBody.java line 94:
> 
>> 92:     private static boolean stopAfterFirstFailure() {
>> 93:         return true;
>> 94:     }
> 
> Any particular reason that this is not just a constant, but a method?

Copy paste from other tests.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29366#issuecomment-3789527251
PR Review Comment: https://git.openjdk.org/jdk/pull/29366#discussion_r2720605180


More information about the net-dev mailing list