RFR: 8376290: SocketChannel.finishConnect() contains confusing "getsockopt" in exception message for a failed connect() on Windows [v3]

Jaikiran Pai jpai at openjdk.org
Mon Jan 26 14:03:20 UTC 2026


On Mon, 26 Jan 2026 13:17:35 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   skip the test if the SocketChannel unexpectedly connects to the destination address
>
> src/java.base/unix/native/libnet/net_util_md.c line 78:
> 
>> 76:             jio_snprintf(fullMsg, sizeof(fullMsg), "socket closed: %s", msg);
>> 77:             JNU_ThrowByName(env, JNU_JAVANETPKG "SocketException", fullMsg);
>> 78:         }
> 
> For for this PR but at some point I'd like to know if the EBADF handling is dead code. It shouldn't happen, at least not with the usages in sun.nio.ch/libnio but maybe there is something that I can't think of.

I've added it to my TODO list and will file a JBS issue after investigating a bit more.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29409#discussion_r2727723238


More information about the net-dev mailing list