RFR: 8378786: PeerConnectionId::cloneBuffer should use absolute bulk get [v2]
Daniel Jeliński
djelinski at openjdk.org
Mon Mar 2 12:09:30 UTC 2026
On Fri, 27 Feb 2026 15:58:55 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> I see. I'm assuming this is the most economic — in terms of, not just LoC, but also complexity — way to inform tests about this unexpected condition.
>
> yes - otherwise you would have to read the logs in order to notice the stack trace there, because simply dropping the packet will typically not make the test to fail (it did not in our case, hence the reason it went unnoticed).
We should probably have a list of exception types that should *not* close the exception instead. But that probably deserves a separate ticket.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29956#discussion_r2872081744
More information about the net-dev
mailing list