RFR: 8378565: Refactor test/jdk/java/net/httpclient/http3/*.java TestNG tests to JUnit [v2]
Daniel Fuchs
dfuchs at openjdk.org
Mon Mar 2 14:13:40 UTC 2026
On Fri, 27 Feb 2026 13:13:37 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - Update test/jdk/java/net/httpclient/http3/H3PushCancel.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update test/jdk/java/net/httpclient/http3/H3ImplicitPushCancel.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update test/jdk/java/net/httpclient/http3/H3ServerPushCancel.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update test/jdk/java/net/httpclient/http3/H3ConcurrentPush.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> @dfuch, LGTM. The conversion is performed with minimal changes. This extremely helped with the review. Thanks so much.
>
> I'm assuming that
>
> 1. You've checked the touched files in an IDE and verified that there are no unused imports, etc.
> 2. Tier 1-2 is clear.
> 3. Copyright years of the touched files are updated accordingly.
@vy if you could re-review - there's only a couple whitespace changes.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29893#issuecomment-3984647285
More information about the net-dev
mailing list