<div dir="auto">Let's please not kill generic BSD support if at all possible. There is NetBSD, OpenBSD, FreeBSD, and DragonflyBSD. I know FreeBSD and NetBSD have OpenJDK 19 and 17 respectively.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 8, 2023, 6:54 PM David Holmes <<a href="mailto:dholmes@openjdk.org" target="_blank" rel="noreferrer">dholmes@openjdk.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs <<a href="mailto:rriggs@openjdk.org" rel="noreferrer noreferrer" target="_blank">rriggs@openjdk.org</a>> wrote:<br>
<br>
> Improvements to support OS specific customization for JDK internal use:<br>
> - To select values and code; allowing elimination of unused code and values<br>
> - Optionally evaluated by build processes, compilation, or archiving (i.e. CDS)<br>
> - Simple API to replace adhoc comparisons with `<a href="http://os.name" rel="noreferrer noreferrer noreferrer" target="_blank">os.name</a>`<br>
> - Clear and consistent use across build, runtime, and JDK modules<br>
> <br>
> The PR includes updates within java.base to use the new API.<br>
<br>
I guess I'm surprised this hasn't been done long before now. :)<br>
<br>
Just a couple of drive by comments (I agree with comments made by others).<br>
<br>
Has this totally killed of BSD support on the JDK side? I thought building non-macOS BSD was still viable, but perhaps not - certainly not after this change.<br>
<br>
Thanks<br>
<br>
src/java.base/share/classes/jdk/internal/misc/OperatingSystem.java line 48:<br>
<br>
> 46: * For example,<br>
> 47: * {@snippet lang = "java":<br>
> 48: * if (OperatingSystem.current() == Windows) {<br>
<br>
Doesn't `Windows` need to be prefixed with `OperatingSystem` here? Ditto for dispatch example following.<br>
<br>
src/java.base/share/classes/jdk/internal/misc/OperatingSystem.java line 105:<br>
<br>
> 103: */<br>
> 104: @ForceInline<br>
> 105: public static boolean isMac() {<br>
<br>
suggestion: isMacOS<br>
<br>
-------------<br>
<br>
PR: <a href="https://git.openjdk.org/jdk/pull/12931" rel="noreferrer noreferrer noreferrer" target="_blank">https://git.openjdk.org/jdk/pull/12931</a><br>
</blockquote></div>