<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello Ryan,</p>
<p>The backporting of fixes into update releases is managed as a
separate project, details of which are available here
<a class="moz-txt-link-freetext" href="https://openjdk.org/projects/jdk-updates/">https://openjdk.org/projects/jdk-updates/</a>. It has its own mailing
list too
<a class="moz-txt-link-freetext" href="https://mail.openjdk.org/mailman/listinfo/jdk-updates-dev">https://mail.openjdk.org/mailman/listinfo/jdk-updates-dev</a>.<br>
</p>
<p>-Jaikiran<br>
</p>
<div class="moz-cite-prefix">On 10/10/24 12:18 am, Ryan Flegel
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CADuiPhWwyasPwdqNfFTU9HpECy6_Pn8bZzQZmJ55NmjXNPmHHQ@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="auto">Hi there,</div>
<div dir="auto"><br>
</div>
<div dir="auto">I'm wondering if someone would be able to review
<div dir="auto"><a
href="https://github.com/openjdk/jdk21u-dev/pull/1020"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jdk21u-dev/pull/1020</a>
for me. There were a couple small merge conflicts.</div>
<div dir="auto"><br>
</div>
<div dir="auto">I did try to cc this list from the PR, but that
didn't seem to work for me. </div>
<div dir="auto"><br>
</div>
<div dir="auto">----</div>
<div dir="auto"><br>
</div>
<div dir="auto">
<div dir="auto">I am backporting this fix because I am being
affected by [JDK-8335181](<a
href="https://bugs.openjdk.org/browse/JDK-8335181"
moz-do-not-send="true" class="moz-txt-link-freetext">https://bugs.openjdk.org/browse/JDK-8335181</a>).
I had to downgrade to HTTP/1.1 in order to use `HttpClient`.</div>
<div dir="auto"><br>
</div>
<div dir="auto">I needed to resolve two minor conflicts in
`MultiExchange.java` due to [JDK-8191494](<a
href="https://bugs.openjdk.org/browse/JDK-8191494"
moz-do-not-send="true" class="moz-txt-link-freetext">https://bugs.openjdk.org/browse/JDK-8191494</a>)
being applied slightly differently in different projects. In
both cases, I kept the change closer to upstream.</div>
<div dir="auto"><br>
</div>
<div dir="auto">The conflicts were:</div>
<div dir="auto">* Explicit vs implicit null field
initialization</div>
<div dir="auto">* Different debug log message</div>
<div dir="auto"><br>
</div>
<div dir="auto">### Tests
All tests in the GitHub actions have passed.</div>
<div dir="auto"><br>
</div>
<div dir="auto">I have run the `jdk/java/net` tests locally
and there were several failures, including 4 within
`java/net/httpclient`. However, I have confirmed that all
the failed tests also fail before applying the patch, so
they seem to be unrelated.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Here is a full list of the failures:</div>
<div dir="auto"><br>
</div>
<div dir="auto">* java/net/DatagramSocket/B6411513.java:
java.net.DatagramSocket.receive: packet isn't received</div>
<div dir="auto">*
java/net/DatagramSocket/SendReceiveMaxSize.java: This test
verifies that on macOS, the send buffer size is configured
by default so that none of our implementations of the UDP
protocol will fail with a "packet too large" exception when
trying to send a packet of the maximum possible size allowed
by the protocol.</div>
<div dir="auto">*
java/net/httpclient/ConnectTimeoutNoProxyAsync.java: Tests
for connection related timeouts</div>
<div dir="auto">*
java/net/httpclient/ConnectTimeoutNoProxySync.java: Tests
for connection related timeouts</div>
<div dir="auto">*
java/net/httpclient/ConnectTimeoutWithProxyAsync.java: Tests
for connection related timeouts</div>
<div dir="auto">*
java/net/httpclient/ConnectTimeoutWithProxySync.java: Tests
for connection related timeouts</div>
<div dir="auto"><br>
</div>
<div dir="auto">UPDATE: I've run the rest of the tier2 tests
and there were two additional JDK failures that appear to be
unrelated:</div>
<div dir="auto"><br>
</div>
<div dir="auto">* com/sun/jndi/dns/ConfigTests/Timeout.java:
Tests that we can set the initial UDP timeout interval and
the number of retries.</div>
<div dir="auto">* com/sun/jndi/ldap/LdapPoolTimeoutTest.java:
Multi-threaded client timeout tests for ldap pool </div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">-- <br>
Ryan</div>
</div>
</div>
</blockquote>
</body>
</html>