<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello Eirik,</p>
<p>The code in URLJarFile which does that check for "~" seems to
have been introduced for
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.org/browse/JDK-4447921">https://bugs.openjdk.org/browse/JDK-4447921</a>. It doesn't tell why
the "~" was necessary.</p>
<p>In any case, I don't think any kind of clean up or introducing
tests for "~" is worth it, given it's not clear what that usage
signifies.<br>
</p>
<p>-Jaikiran<br>
</p>
<div class="moz-cite-prefix">On 26/03/25 3:43 pm, Eirik Bjørsnøs
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CA+pBWhu9q9b34pgf9-JN0q+DaRAik=pwFgEkeGhGhwAzY=HWzA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">Hi,<br>
<div><br>
</div>
<div>Various URL scheme code paths contain branches for local or
non-local file URLs:</div>
<div><br>
</div>
<div>See URLJarFile::isFileURL for an example where the host is
compared as follows:</div>
<div><br>
</div>
<blockquote style="margin:0 0 0 40px;border:none;padding:0px"><font
face="monospace">String host = url.getHost();<br>
</font><font face="monospace">if (host == null ||
host.isEmpty() || host.equals("~") ||<br>
</font><font face="monospace">
host.equalsIgnoreCase("localhost"))</font>
<div><font face="monospace"> return true; </font></div>
</blockquote>
<div><br>
</div>
<div>Equivalent checks are found in unix and windows
Handler::openConnection.</div>
<div><br>
</div>
<div>In JarFileFactory::urlFor however, the logic is slightly
different in that the comparison with ~ (tilde) is missing:</div>
<div><br>
</div>
<blockquote style="margin:0 0 0 40px;border:none;padding:0px">
<div><font face="monospace">String host = url.getHost();</font></div>
<div><font face="monospace">if (host != null &&
!host.isEmpty() &&</font></div>
<div><font face="monospace">
!host.equalsIgnoreCase("localhost")) {</font></div>
<div><br>
</div>
</blockquote>
<div>I have tried to find an RFC or any other mention of "~" in
host names, but found nothing. Can anyone shine light on the
meaning and interpretation of this character as a host name?</div>
<div><br>
</div>
<div>In any case, I think if we could add the tilde logic
to JarFileFactory::urlFor, then all these four checks would be
equivalent and a prime candidate for a consolidating cleanup
PR, perhaps also expanding a bit on the documentation for the
consolidated method(s).</div>
<div><br>
</div>
<div>My take is that the missing test was a simple oversight,
that adding it should not be harmful and that this would
enable a nice consolidation of this particular logic. .</div>
<div><br>
</div>
<div>Thoughts?</div>
<div><br>
</div>
<div>Eirik.</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
</div>
</blockquote>
</body>
</html>