<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Alan,<br>
<br>
I wanted to follow up on the update I shared earlier</div>
<div class="elementToProof" style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I’ve successfully backported the preClose re-order changes to <b>JDK 17</b> and ran the
<code>Race.java</code> test case <b>500 times</b>. It passed consistently without any failures. For validation, I also ran the test
<b>without the patch</b>, and it failed on the <b>first iteration</b>. I ran the tests under
<b>java/nio</b> to see if there is any regression and all the testcases are passing.</div>
<div class="elementToProof" style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Currently, we are running the tests under <code>java/net</code>.</div>
<ul data-end="802" data-start="667">
<li style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<div style="margin-top: 1em; margin-bottom: 1em;">Do you recommend running any additional test groups?</div>
</li><li style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<div style="margin-top: 1em; margin-bottom: 1em;">Also, can we proceed with porting the preClose re-order fix to
<b>headstream</b>?</div>
</li></ul>
<div class="elementToProof" style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Please let me know your thoughts.</div>
<div class="elementToProof" style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks<br>
Shruthi</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Shruthi . <Shruthi.Shruthi1@ibm.com><br>
<b>Sent:</b> Friday, May 23, 2025 6:27 PM<br>
<b>To:</b> Alan Bateman <alan.bateman@oracle.com>; net-dev@openjdk.org <net-dev@openjdk.org><br>
<b>Cc:</b> Syed Moinudeen <smoinud1@in.ibm.com>; SREENIVAS MAKINEEDI <sreeni@us.ibm.com><br>
<b>Subject:</b> Re: [EXTERNAL] Re: Suggestion needed to port the fix to JDK17 and JDK11S</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hi Alan,</div>
<div class="x_elementToProof" style="height:8px; display:block"></div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
I was able to backport the preClose re-order changes to JDK17 and I executed the Race.java testcase 500 times, and it passed consistently without any failures.</div>
<div class="x_elementToProof" style="height:8px; display:block"></div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
I also tested Race.java without the patch and it fails in the first iteration it self.</div>
<div class="x_elementToProof" style="height:8px; display:block"></div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
We are running the tests under java/net and java/nio to check if there is any regression. Do you think I should run any other tests?</div>
<div class="x_elementToProof" style="height:8px; display:block"></div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Also, can we proceed with porting preClose re-order fix to headstream?<br>
<br>
Thanks<br>
Shruthi</div>
<div id="x_appendonsend"></div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Shruthi . <Shruthi.Shruthi1@ibm.com><br>
<b>Sent:</b> Tuesday, April 8, 2025 6:03 PM<br>
<b>To:</b> Alan Bateman <alan.bateman@oracle.com>; net-dev@openjdk.org <net-dev@openjdk.org><br>
<b>Cc:</b> Syed Moinudeen <smoinud1@in.ibm.com>; SREENIVAS MAKINEEDI <sreeni@us.ibm.com><br>
<b>Subject:</b> Re: [EXTERNAL] Re: Suggestion needed to port the fix to JDK17 and JDK11S</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div class="x_x_elementToProof" style="margin-top:1em; margin-bottom:1em; font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hi Alan,<br>
<br>
I was able to successfully build the OpenJDK headstream with the <code>preClose</code> reordering patch, which you have shared:
<a href="https://bugs.openjdk.org/secure/attachment/113740/pending_signals.patch" target="_new" id="OWA4250d9d3-9cc2-030f-68e1-8038c8075a0b" class="x_x_OWAAutoLink" rel="noopener" data-start="213" data-end="309">
pending_signals.patch</a>.</div>
<div class="x_x_elementToProof" style="margin-top:1em; margin-bottom:1em; font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
To validate the build, I executed the <code>Race.java</code> testcase 500 times, and it passed consistently without any failures.</div>
<div class="x_x_elementToProof" style="margin-top:1em; margin-bottom:1em; font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
For comparison, I ran the same testcase without the patch, and it failed on the 86th iteration.<br>
<br>
Thanks<br>
Shruthi</div>
<div id="x_x_appendonsend"></div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Alan Bateman <alan.bateman@oracle.com><br>
<b>Sent:</b> Friday, March 14, 2025 3:00 PM<br>
<b>To:</b> Shruthi . <Shruthi.Shruthi1@ibm.com>; net-dev@openjdk.org <net-dev@openjdk.org><br>
<b>Cc:</b> Syed Moinudeen <smoinud1@in.ibm.com>; SREENIVAS MAKINEEDI <sreeni@us.ibm.com><br>
<b>Subject:</b> [EXTERNAL] Re: Suggestion needed to port the fix to JDK17 and JDK11S</font>
<div> </div>
</div>
<div>
<div style="display:none!important; display:none; visibility:hidden; font-size:1px; color:#ffffff; line-height:1px; height:0px; max-height:0px; opacity:0; overflow:hidden">
On 14/03/2025 09: 22, Shruthi . wrote: The issue which we are seeing is not reproducible in JDK21 or higher version Okay, so you might be chasing a different issue? For the JDK then maybe we need more stress tests for async close, maybe that</div>
<div style="display:none!important; display:none; visibility:hidden; font-size:1px; color:#ffffff; line-height:1px; max-height:0px; opacity:0; overflow:hidden">
</div>
<style>
<!--
#x_x_x_pfptBannerx13sskt
{display:block!important;
visibility:visible!important;
opacity:1!important;
background-color:#D0D8DC!important;
max-width:none!important;
max-height:none!important}
-->
</style>On 14/03/2025 09:22, Shruthi
. wrote:<br>
<blockquote type="cite"><style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div class="x_x_x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
The issue which we are seeing is not reproducible in JDK21 or higher version</div>
<br>
</blockquote>
Okay, so you might be chasing a different issue? For the JDK then maybe we need more stress tests for async close, maybe that would help you reproduce it with main line.<br>
<br>
-Alan<br>
</div>
</div>
</div>
</body>
</html>