<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Alan,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I ran the tests under java/nio and java/net against the JDK 17 build with the preClose re-order change to check for any regressions, and all tests passed successfully.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Three patches need to be ported to implement this fix in JDK 17 and to keep the source code aligned with the OpenJDK headstream.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
* 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl (https://github.com/openjdk/jdk/pull/10434)</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
* 8351458: (ch) Move preClose to UnixDispatcher (https://github.com/openjdk/jdk/pull/23956)</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
* 8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix) (https://bugs.openjdk.org/secure/attachment/113740/pending_signals.patch)</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I have raised a backport PR in JDK17 for 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
https://github.com/openjdk/jdk17u-dev/pull/3631 - I have tagged you here. Can you please review</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I have raised the OpenJDK headstream PR for 8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix)</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
https://github.com/openjdk/jdk/pull/25817 - I have tagged you here. Can you please review</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Will proceed with the rest of the patches accordingly.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Shruthi</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Alan Bateman <alan.bateman@oracle.com><br>
<b>Sent:</b> Sunday, June 8, 2025 10:52 PM<br>
<b>To:</b> Shruthi . <Shruthi.Shruthi1@ibm.com>; net-dev@openjdk.org <net-dev@openjdk.org><br>
<b>Cc:</b> Syed Moinudeen <smoinud1@in.ibm.com>; SREENIVAS MAKINEEDI <sreeni@us.ibm.com><br>
<b>Subject:</b> [EXTERNAL] Re: Suggestion needed to port the fix to JDK17 and JDK11S</font>
<div> </div>
</div>
<div>
<div style="display:none!important; display:none; visibility:hidden; font-size:1px; color:#ffffff; line-height:1px; height:0px; max-height:0px; opacity:0; overflow:hidden">
On 31/05/2025 20: 12, Shruthi . wrote: Hi Alan, I wanted to follow up on the update I shared earlier I’ve successfully backported the preClose re-order changes to JDK 17 and ran the Race. java test case 500 times. It passed consistently without</div>
<div style="display:none!important; display:none; visibility:hidden; font-size:1px; color:#ffffff; line-height:1px; max-height:0px; opacity:0; overflow:hidden">
</div>
<style>
<!--
#x_pfptBanner2bszmnj
{display:block!important;
visibility:visible!important;
opacity:1!important;
background-color:#D0D8DC!important;
max-width:none!important;
max-height:none!important}
-->
</style>On 31/05/2025 20:12, Shruthi
. wrote:<br>
<blockquote type="cite"><style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div class="x_elementToProof" style="margin-top:1em; margin-bottom:1em; font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hi Alan,<br>
<br>
I wanted to follow up on the update I shared earlier</div>
<div class="x_elementToProof" style="margin-top:1em; margin-bottom:1em; font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
I’ve successfully backported the preClose re-order changes to <b>JDK 17</b> and ran the
<code>Race.java</code> test case <b>500 times</b>. It passed consistently without any failures. For validation, I also ran the test
<b>without the patch</b>, and it failed on the <b>first iteration</b>. I ran the tests under
<b>java/nio</b> to see if there is any regression and all the testcases are passing.</div>
<div class="x_elementToProof" style="margin-top:1em; margin-bottom:1em; font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Currently, we are running the tests under <code>java/net</code>.</div>
<ul data-end="802" data-start="667">
<li style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<div style="margin-top:1em; margin-bottom:1em">Do you recommend running any additional test groups?</div>
</li><li style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<div style="margin-top:1em; margin-bottom:1em">Also, can we proceed with porting the preClose re-order fix to
<b>headstream</b>?</div>
</li></ul>
<div class="x_elementToProof" style="margin-top:1em; margin-bottom:1em; font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Please let me know your thoughts.</div>
</blockquote>
<br>
Good to hear that the preClose changes helped. I think the next step is to create a PR for JDK main line.<br>
<br>
-Alan<br>
</div>
</body>
</html>