Need reviewer for 6900234: Several NIO tests should be removed from test/ProblemList.txt
Christopher Hegarty - Sun Microsystems Ireland
Christopher.Hegarty at Sun.COM
Wed Nov 11 08:18:23 PST 2009
These changes seem fine.
-Chris.
On 11/11/2009 14:49, Alan Bateman wrote:
>
> The exclude list (jdk/test/ProblemList.txt) that Kelly pushed with
> 6888927 lists several NIO tests that I'd to remove from the list.
>
> The test that I'd like to remove from the list are:
>
> java/nio/channels/Selector/SelectAfterRead.java
> java/nio/channels/SocketChannel/CloseAfterConnect.java
> java/nio/channels/SocketChannel/CloseRegisteredChannel.java
> java/nio/channels/SocketChannel/Shutdown.java
> java/nio/channels/SocketChannel/SocketOptionTests.java
> java/nio/channels/SocketChannel/Stream.java
> These shouldn't have been excluded - it looks like they failed for Kelly
> in his initial runs because there of a (now-excluded) test that consumed
> all resources.
>
> java/nio/channels/AsynchronousChannelGroup/Unbounded.java
> This one creates 512 loopback connections and hits the file descriptor
> limits on Linux machines that have the limit set to 1024. There isn't
> any need for this test to create so many connections so I've reduce the
> connection count.
>
> java/nio/file/Path/CopyAndMove.java
> java/nio/file/Path/Links.java
> These two fail in samevm mode because they read symbolic links and
> jtreg's security manager doesn't yet allow this action. For now the
> simplest thing is to run these tests in othervm mode:
>
> java/nio/channels/FileChannel/Transfer.java
> The comment for this one suggested it was failing on Windows 2000 but I
> haven't duplicated this. Instead, I suspect it was failing due to a
> timeout - on Windows the test runs perilous close to the timeout so I
> propose to increase the timeout so that it won't cause problems.
>
> Attached are the diffs (trivial).
>
> Thanks,
> Alan.
>
> diff -r 18c2b761548a test/ProblemList.txt
> --- a/test/ProblemList.txt Wed Nov 11 14:38:01 2009 +0000
> +++ b/test/ProblemList.txt Wed Nov 11 14:42:49 2009 +0000
> @@ -741,9 +741,6 @@ com/sun/nio/sctp/SctpMultiChannel/Send.j
> com/sun/nio/sctp/SctpMultiChannel/Send.java generic-all
> com/sun/nio/sctp/SctpMultiChannel/SocketOptionTests.java generic-all
>
> -# Linux 64bit failures. too many files open (not good for windows 2000
> either)
> -java/nio/channels/AsynchronousChannelGroup/Unbounded.java generic-all
> -
> # Linux 64bit failures. too many files open
> java/nio/channels/Selector/HelperSlowToDie.java
> generic-all
>
> @@ -771,9 +768,6 @@ java/nio/channels/DatagramChannel/Connec
> # Solaris i586 timeouts
> java/nio/channels/DatagramChannel/EmptyBuffer.java solaris-all
>
> -# Gets java.lang.ExceptionInInitializerError on windows: (Windows 2000
> only?)
> -java/nio/channels/FileChannel/Transfer.java windows-5.0
> -
> # Failed loopback connection? On windows 32bit?
> # Considered a stress test, can consume all resources.
> java/nio/channels/Selector/LotsOfChannels.java generic-all
> @@ -785,18 +779,11 @@ java/nio/channels/Selector/OpRead.java
> # Considered a stress test, can consume all resources.
> java/nio/channels/Selector/RegAfterPreClose.java generic-all
>
> -# Gets java.net.BindException alot (static port number?)
> -java/nio/channels/Selector/SelectAfterRead.java generic-all
> -
> # Solaris i586, cannot assign address, samevm issues
> java/nio/channels/Selector/SelectorLimit.java generic-all
>
> # Socket timeout windows X64
> java/nio/channels/ServerSocketChannel/AdaptServerSocket.java windows-all
> -
> -# Solaris i586, cannot assign address, samevm issues
> -java/nio/channels/SocketChannel/CloseAfterConnect.java generic-all
> -java/nio/channels/SocketChannel/CloseRegisteredChannel.java generic-all
>
> # Timeouts etc. on Window
> java/nio/channels/SocketChannel/ConnectState.java windows-all
> @@ -805,11 +792,6 @@ java/nio/channels/SocketChannel/FinishCo
> # Need to be marked othervm, or changed to be samevm safe
> java/nio/channels/SocketChannel/OpenLeak.java generic-all
>
> -# Solaris i586 java.net.BindExceptions
> -java/nio/channels/SocketChannel/Shutdown.java solaris-all
> -java/nio/channels/SocketChannel/SocketOptionTests.java solaris-all
> -java/nio/channels/SocketChannel/Stream.java solaris-all
> -
> # Gets java.net.BindException alot (static port number?)
> java/nio/channels/SocketChannel/VectorIO.java generic-all
>
> @@ -818,10 +800,6 @@ java/nio/channels/SocketChannel/VectorPa
>
> # Linux i586 address already in use, samevm issues
> java/nio/channels/SocketChannel/Write.java generic-all
> -
> -# Fails in samevm, jtreg security manager does not grant FilePermission
> readlink action
> -java/nio/file/Path/CopyAndMove.java generic-all
> -java/nio/file/Path/Links.java generic-all
>
> # Fails on all platforms due to overlap of JDK jar file contents:
> sun/nio/cs/Test4200310.sh generic-all
> diff -r 18c2b761548a
> test/java/nio/channels/AsynchronousChannelGroup/Unbounded.java
> --- a/test/java/nio/channels/AsynchronousChannelGroup/Unbounded.java
> Wed Nov 11 14:38:01 2009 +0000
> +++ b/test/java/nio/channels/AsynchronousChannelGroup/Unbounded.java
> Wed Nov 11 14:42:49 2009 +0000
> @@ -34,7 +34,7 @@ import java.io.IOException;
>
> public class Unbounded {
> // number of concurrent completion handlers
> - static final int CONCURRENCY_COUNT = 512;
> + static final int CONCURRENCY_COUNT = 256;
>
> public static void main(String[] args) throws Exception {
> // all accepted connections are added to a queue
> diff -r 18c2b761548a test/java/nio/channels/FileChannel/Transfer.java
> --- a/test/java/nio/channels/FileChannel/Transfer.java Wed Nov 11
> 14:38:01 2009 +0000
> +++ b/test/java/nio/channels/FileChannel/Transfer.java Wed Nov 11
> 14:42:49 2009 +0000
> @@ -25,6 +25,7 @@
> * @bug 4434723 4482726 4559072 4638365 4795550 5081340 5103988 6253145
> * @summary Test FileChannel.transferFrom and transferTo
> * @library ..
> + * @run main/timeout=180 Transfer
> */
>
> import java.io.*;
> diff -r 18c2b761548a test/java/nio/file/Path/CopyAndMove.java
> --- a/test/java/nio/file/Path/CopyAndMove.java Wed Nov 11 14:38:01 2009
> +0000
> +++ b/test/java/nio/file/Path/CopyAndMove.java Wed Nov 11 14:42:49 2009
> +0000
> @@ -25,6 +25,8 @@
> * @bug 4313887 6838333
> * @summary Unit test for java.nio.file.Path copyTo/moveTo methods
> * @library ..
> + * @build CopyAndMove
> + * @run main/othervm CopyAndMove
> */
>
> import java.nio.ByteBuffer;
> diff -r 18c2b761548a test/java/nio/file/Path/Links.java
> --- a/test/java/nio/file/Path/Links.java Wed Nov 11 14:38:01 2009
> +0000
> +++ b/test/java/nio/file/Path/Links.java Wed Nov 11 14:42:49 2009
> +0000
> @@ -26,6 +26,8 @@
> * @summary Unit test for java.nio.file.Path createSymbolicLink,
> * readSymbolicLink, and createLink methods
> * @library ..
> + * @build Links
> + * @run main/othervm Links
> */
>
> import java.nio.file.*;
>
More information about the nio-dev
mailing list