Need review for 6873621: (file) FileStore.supportsFileAttributeView(Class<FileAttributeView> type) returns wrong result

Alan Bateman Alan.Bateman at Sun.COM
Fri Sep 4 07:03:00 PDT 2009


Andrew John Hughes wrote:
> :
> Looks good to me.  I like the idea of making this safer by checking
> against a type rather than an arbitrary String.  This also makes these
> classes match UnixFileStore which already does this for the
> PosixFileAttributeView.
>   
Thanks.

> As an aside, I noticed that Solaris is the only implementation to use
> AclFileAttributeView.  Don't both Linux and Windows have some form of
> ACL support?  Something to fix long term I guess.
>   
It's supported on Windows too - the API is based on the NFSv4 ACL model 
(RFC 3530) which was based on the Windows NT ACL model (a few 
differences but well understood). We don't have any support for ACLs on 
Linux, not yet anyway. It's a while since I looked into this but there 
was a patch available to support them on ext3 but not NFS. Also, at the 
time, I didn't find any distributions that shipped with the support.  My 
understanding might be stale, but definitely something to add in the future.

-Alan.


More information about the nio-dev mailing list