Need review for 6873621: (file) FileStore.supportsFileAttributeView(Class<FileAttributeView> type) returns wrong result
Alan Bateman
Alan.Bateman at Sun.COM
Fri Sep 4 07:03:36 PDT 2009
Andrew John Hughes wrote:
> :
> In supportsFileAttributeView(Class<? extends FileAttributeView) in
> UnixFileStore, the following:
>
> FeatureStatus status = checkIfFeaturePresent("posix");
> if (status == FeatureStatus.NOT_PRESENT)
> return false;
> return true;
>
> could be changed to simply:
>
> FeatureStatus status = checkIfFeaturePresent("posix");
> return (status != FeatureStatus.NOT_PRESENT)
>
> or even:
>
> return checkIfFeaturePresent("posix") != FeatureStatus.NOT_PRESENT;
>
> as part of your patch.
>
Makes sense - I'll do that - thanks!
-Alan.
More information about the nio-dev
mailing list