-Werror in make/java/sun_nio/Makefile

Alan Bateman Alan.Bateman at Sun.COM
Mon Feb 1 04:49:51 PST 2010


Andrew John Hughes wrote:
> :
> Ok, that's what I've done in this webrev:
>
> http://cr.openjdk.java.net/~andrew/warnings/webrev.01/
>
> It also fixes a number of unchecked and redundant cast warnings that
> occur when building with JAVAC_MAX_WARNINGS=true.  With this patch,
> sun_io now compiles when JAVAC_MAX_WARNINGS=true.
>
> Does this look ok?
>   
Looks good to me. I think this is first webrev that I've reviewed with 
changes that make use of the diamond operator.

I've created a bug to track this:
  6921740: Eliminate warnings from sun.io converters and allow compiling 
with JAVAC_MAX_WARNINGS=true

-Alan.



More information about the nio-dev mailing list