[Fwd: Re: -Werror in make/java/sun_nio/Makefile]

[Xueming Shen]

Looks fine.

Sherman


>
> ------------------------------------------------------------------------
>
> Subject:
> Re: -Werror in make/java/sun_nio/Makefile
> From:
> Andrew John Hughes <gnu_andrew at member.fsf.org>
> Date:
> Sat, 30 Jan 2010 02:19:55 +0000
> To:
> Alan Bateman <Alan.Bateman at Sun.COM>
>
> To:
> Alan Bateman <Alan.Bateman at Sun.COM>
> CC:
> nio-dev <nio-dev at openjdk.java.net>
>
>
> On 28 January 2010 23:15, Alan Bateman <Alan.Bateman at sun.com> wrote:
>   
>> Andrew John Hughes wrote:
>>     
>>> :
>>>
>>> It seems that ByteToCharConverter was marked as deprecated with the
>>> intention of removing it in JDK6:
>>>
>>>  * @deprecated Replaced by {@link java.nio.charset}.  THIS API WILL BE
>>>  * REMOVED IN J2SE 1.6.
>>>
>>> This still being present in OpenJDK7 suggests that never happened.
>>>
>>>       
>> Unfortunately we haven't been able to remove the legacy converters as
>> planned. JDBC drivers are the main problem. Sherman and Martin may want to
>> chime in with more history on this.
>>
>>     
>>> I'd suggest we either drop the local -Werror or add -deprecation after
>>> serial to make the build with maximum warnings complete.  Long term,
>>> we can look at getting rid of that code if appropriate, though I doubt
>>> we'll ever be able to do a build with the deprecation warning and
>>> -Werror on simply because of legacy code.
>>>
>>>       
>> I'd prefer not drop -Werror as that would let warnings creep in. Add
>> -deprecation is probably better.
>>
>>     
>
> Ok, that's what I've done in this webrev:
>
> http://cr.openjdk.java.net/~andrew/warnings/webrev.01/
>
> It also fixes a number of unchecked and redundant cast warnings that
> occur when building with JAVAC_MAX_WARNINGS=true.  With this patch,
> sun_io now compiles when JAVAC_MAX_WARNINGS=true.
>
> Does this look ok?
>
>   
>> -Alan.
>>
>>     
>
>
>
>