Need reviewer for 6925932: (file) Path.endsWith can throw ArrayIndexOutOfBoundsException (unx)
Alan Bateman
Alan.Bateman at Sun.COM
Sat Feb 20 08:34:36 PST 2010
Christopher Hegarty - Sun Microsystems Ireland wrote:
> Looks fine.
>
> Trivially, I would retrieve and store path.length and that.path.length
> in locals after checkPath(other), to prevent retrieving their values
> potentially more than once.
Thanks Chris. You're right, it could be nicer to assign thisLen and
thatLen at start of the method. I'll do that, re-test and push the fix.
-Alan
More information about the nio-dev
mailing list