Need reviewer for 6926800: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with newer versions of find(1)

Alan Bateman Alan.Bateman at Sun.COM
Sat Feb 20 11:52:11 PST 2010


Rémi Forax wrote:
> :
> This is my first review with a switch on string :)
>
> The patch is ok.
>
> I think that the doc of visitFile should be modified to add
> a sentence about the fact that visiFile can be called with
> a link to a directory.
> The fact that attrs.isDirectory() can be true is surprising.
Thanks for reviewing. Files.walkFileTree has a paragraph on this and 
that's where it specifies how cycles are reported. Adding a reference 
from visitFile is probably a good idea when next updating that part of 
the javadoc.

-Alan.


More information about the nio-dev mailing list