WatchService questions

Alan Bateman Alan.Bateman at Sun.COM
Wed Jan 13 10:02:32 PST 2010


Sebastian Sickelmann wrote:
> :
> I add the two diffs to this mail. Tomorrow i will try using nice looking webrev-output.
>
> The diffs are based on: [2]
>   
I skimmed through both patches. Looks like they are close with the only 
difference that the first patch (2A.diff) preserves the ordering of 
modify events relative to non-modify events for other files. In 
practical terms there probably isn't too much of a difference but 
2B.diff may be slightly more efficient if the user falls way behind and 
there are lots of files being of changes going on at the same time that 
lots of files are being created and deleted.

One thing that doesn't look right is that pollEvents doesn't seem to be 
clear the map of modify events - that would be important to avoid 
incrementing the count on events that have already been retrieved by the 
user.

> :
> I am using JDK_IMPORT_PATH but got problems while building nio only.
>   
That's used when you aren't building the entire JDK. Even though you are 
doing a partial build you will still need to build the entire jdk 
repository. Once you've got a build then you can do into the 
make/java/nio directory to do incremental builds of just this area.

-Alan.


More information about the nio-dev mailing list