Need reviewer for 6917021: (file) copyTo/moveTo can overrwrite existing file when target associated with custom provider
Christopher Hegarty -Sun Microsystems Ireland
Christopher.Hegarty at Sun.COM
Mon Jan 18 06:51:06 PST 2010
Alan Bateman wrote:
> When the copyTo/moveTo methods are invoked with a target that is
> associated with a custom file system then a simple copy/move
> implementation is used rather than the implementation for the platform.
> Thomas Salter pointed out a bug in this code whereby it could override a
> target file even when the REPLACE_EXISTING option is not used. The bug
> highlights that the current copy/move tests don't exercise the foreign
> provider case. The patch proposed extends the existing test for this
> case. In addition to the issue that Thomas ran into, the tests exposed
> two minor issues where the wrong exception is thrown.
>
> The webrev with the changes is here:
> http://cr.openjdk.java.net/~alanb/6917021/webrev/
These changes look fine. Although, I'll admit I just scanned the test
changes.
-Chris.
>
> Thanks,
> Alan.
More information about the nio-dev
mailing list