WatchService questions

[Sebastian Sickelmann]

Hi,

in the attachment you can find the two Mercurial Exports. (Version 2A and Version2B)

> Alan Bateman wrote:
> I skimmed through both patches. Looks like they are close with the only 
> difference that the first patch (2A.diff) preserves the ordering of 
> modify events relative to non-modify events for other files. In 
> practical terms there probably isn't too much of a difference but 
> 2B.diff may be slightly more efficient if the user falls way behind and 
> there are lots of files being of changes going on at the same time that 
> lots of files are being created and deleted.
I have found an additional interesting thing in WatchService. What are those Modifiers by the registering for. Should there be a Modifier to turn on the merging of MODIFY-Events?
Maybe the Level of Merging (Version2A and Version2B)?
It looks to me that the SensitivityModfies does some comparable feature than merging(reducing) MODIFY-Events.

> 
> One thing that doesn't look right is that pollEvents doesn't seem to be 
> clear the map of modify events - that would be important to avoid 
> incrementing the count on events that have already been retrieved by the 
> user.
Thanks, you are totally right. This is corrected in the diffs and the testcases.
-- 
GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hg.WatchServer.2A.export
Type: application/octet-stream
Size: 19527 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20100119/f7c1a3d2/attachment-0002.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hg.WatchServer.2B.export
Type: application/octet-stream
Size: 20235 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20100119/f7c1a3d2/attachment-0003.obj