-Werror in make/java/sun_nio/Makefile

[Alan Bateman]

Andrew John Hughes wrote:
> :
>
> It seems that ByteToCharConverter was marked as deprecated with the
> intention of removing it in JDK6:
>
>  * @deprecated Replaced by {@link java.nio.charset}.  THIS API WILL BE
>  * REMOVED IN J2SE 1.6.
>
> This still being present in OpenJDK7 suggests that never happened.
>   
Unfortunately we haven't been able to remove the legacy converters as 
planned. JDBC drivers are the main problem. Sherman and Martin may want 
to chime in with more history on this.

> I'd suggest we either drop the local -Werror or add -deprecation after
> serial to make the build with maximum warnings complete.  Long term,
> we can look at getting rid of that code if appropriate, though I doubt
> we'll ever be able to do a build with the deprecation warning and
> -Werror on simply because of legacy code.
>   

I'd prefer not drop -Werror as that would let warnings creep in. Add 
-deprecation is probably better.

-Alan.