zipfs patches
Alan Bateman
Alan.Bateman at Sun.COM
Sat Jan 30 11:51:59 PST 2010
Joel Uckelman wrote:
> Two more zipfs patches:
>
> * Implemented readAttributes().
> * copyTo() should return target, not this.
>
>
Thanks for taking these bugs. The map key is the attribute name rather
than view:attribute and so I assume map.put(attr, ..) should be
map.put(name, ...). Another comment is that you've implemented it to use
getAttribute, and if I read the patch correctly, it means that a bulk
read turns into a sequence of gets where each reads the zip entry. With
caching this might not be noticeable but I'm interested to know if
you've compared it to reading the zip entry once and then populating the
map with the requested attributes.
-Alan.
More information about the nio-dev
mailing list