Need reviewer for 6931216: TEST_BUG: test/java/nio/file/WatchService/LotsOfEvents.java failed with NPE

Alan Bateman Alan.Bateman at Sun.COM
Tue Mar 2 08:36:04 PST 2010


Christopher Hegarty - Sun Microsystems wrote:
> Looks fine.
>
> BTW, I don't think the first part of the change is necessary since the 
> enclosing method is never called with count <= 0, but it is certainly 
> good practice and may prevent future failures if this tests evolves.  
That's right and I should have mentioned it - I only changed 
drainAndCheckOverflowEvents to keep it consistent. Thanks for reviewing.

-Alan.




More information about the nio-dev mailing list