Code review request for 6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6 workspace

[Seán Coffey]

Alan,

comments inline.

http://cr.openjdk.java.net/~coffeys/6974104/webrev.01/

On 14/10/2010 16:11, Alan Bateman wrote:
> Seán Coffey wrote:
>>  I'd like to add a testcase for 6645197 to the jdk 7 workspace.
>>
>> 6645197 was recently fixed in jdk6 and this is the same testcase
>> being forward ported.
>>
>> webrev :  http://cr.openjdk.java.net/~coffeys/6974104/webrev.00/
>>
>> Regards,
>> Sean.
> Thanks for contributing a test for this. I have a couple of comments:
>
> I would it better to name this something like TemporarySelector?
Done.
>
> Does the test need to run in othervm mode? I see you specify a max 
> heap of 5MB so I'm wondering if you were able to duplicate it with any 
> heap size. I remember when Sherman fixed this bug originally and I 
> don't think he could create a reliable test at the time. If you do 
> change it to run in samevm mode the server socket channel and the 
> accepted channel will need to be closed so that the test doesn't 
> complete leaving channels open.
Yes - jtreg doesn't appear to allow the use of Xmx flags when run in 
samevm mode. The reduced heap size is necessary to make sure the GC 
cycles are run good and early in the testcase. I didn't see the failure 
occur at 64MB heap size when socket timeout was for 20 seconds.
>
> It would be good if it duplicated in less than 20s - related to the 
> samevm comment we've been trying to get the test times down.
Socket timeout of 5 second sees testcase not failing. Socket timeout of 
10 seconds works. I've changed it to 10 seconds for performance.
>
> I don't think the acceptor thread is needed as you just need a 
> loopback connection to run this test. You'll see examples in several 
> of the other tests if it helps.
You're right here. I'm not too used to networking testcases. Changes 
made as suggested.


http://cr.openjdk.java.net/~coffeys/6974104/webrev.01/

regards,
Sean.
>
> -Alan
>
>
>
>