6816049: (bf) MappedByteBuffer.force() method does not flush data correctly

Alan Bateman Alan.Bateman at oracle.com
Fri Oct 22 06:08:34 PDT 2010


Chris Hegarty wrote:
> Looks fine, some minor comments:
>
> The Direct-X-Buffer constructors, not for memory-mapped buffers, can 
> simply invoke 4 arg super constructor, instead of passing a null fd, 
> right? Thought, this was always the case.
Good idea, that would be cleaner.

>
> The indentation of L55 (2nd line of args to force0) of the windows 
> version of MappedByteBuffer.c seems wrong (too much). Or maybe this is 
> webrev.
Windows and 8 space tabbing more likely.

I've updated the webrev, and thanks for reviewing.

-Alan.


More information about the nio-dev mailing list