Code review request : 7047325

Seán Coffey sean.coffey at oracle.com
Wed Aug 10 09:23:29 PDT 2011


Thanks for catching that Mike. The API is internal in any case and 
javadoc won't be public.

webrev updated. I've updated the capacity-> cap comment. (and an 
erroneous "is an" )

Testcase to accompany the internal API code.

regards,
Sean.

On 08/10/2011 04:40 PM, Mike Duigou wrote:
> src/share/classes/sun/misc/JavaNioAccess.java:
> - the javadoc refers to {@code capacity} whereas the actual param is named "cap". Any reason to us a prose description rather than @param tags?
>
> src/share/classes/java/nio/Direct-X-Buffer.java.template:
> - The comment upon "att" is not a javadoc comment. (this also seems to apply to many other comments in this file).
>
> unit test updates or additions?
>
> Mike
>
> On Aug 10 2011, at 01:34 , Seán Coffey wrote:
>
>> CR 7047325 is an internal RFE : Internal API to improve management of direct buffers
>>
>> This RFE was introduced in a 6 update release and with jdk 7&  jdk 8 in the open, I'm porting this change forward from the proprietary jdk6 updates. The change adds an internal API to improve the management of direct buffers.
>>
>> This request is for jdk 8 : http://cr.openjdk.java.net/~coffeys/7047325.jdk8/
>>
>> regards,
>> Sean.


More information about the nio-dev mailing list