Code Review Request: 7060243: (dc) Multicasting tests fail on Windows XP if IPv6 is enabled

[Alan Bateman]

Kurchi Hazra wrote:
>
> Hi,
>
>    java/nio/channels/DatagramChannel/BasicMulticastTests.java and 
> java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java were 
> throwing an UnSupportedOperationException on Windows XP 32 bit,
> with an IPV6 stack, since NIO Channels do not support the old stack. 
> Both these testcases rely on the InetAddresses returned by probe() in 
> test/java/nio/channels/DatagramChannel/NetworkConfiguration.java.
> Hence, the fix was to modify probe() in NetworkConfiguration.java to 
> not return the list of IPV6 InetAddresses if the OS is Windows and the 
> version is lower than 6.
Thanks Kurchi, this was an oversight in the test as IPv6 isn't enabled 
on Windows XP/2003 by default. Changing the probe method filter out IPv6 
addresses is right and thanks for doing that. A couple of minor nits, is 
that this is a helper class used by the tests and so shouldn't have the 
@bug tag. Also the coding style in isIpv6Supported is a bit inconsistent 
with the the rest of the tests. I can fix these up before pushing the 
fix and I'll push it list you as contributer.

-Alan.