7076310: (file) AclEntry.Builder setFlags throws IllegalArgumentException if set argument is empty

[Alan Bateman]

On 22/12/2011 02:29, Stephen Flores wrote:
> Alan,
>
> Please review the updated the webrev:
>
>   http://cr.openjdk.java.net/~sflores/7076310/webrev.00/
>
> In setFlags(Set) "new HashSet" was changed to "Collections.emptySet"  
> to match the AclEntry constructor.
>
> setPermissions(Set) was changed in the same way setFlags(Set) was 
> changed.
>
> The unit test was moved to .../AclEntry/EmptySet.java.
>
> An assert for setPermissions was added to EmptySet.
The change looks okay to me. The block comments added to setPermissions 
and setFlags is slightly different in style to the other comments. Since 
this is so minor then it's not worth generating a new webrev and I can 
sort it out when pushing the patch.

On the test then it's fine for now but I would like to replace it at 
some point with a complete unit test (as I mentioned, the reason this 
one slipped through it because we are missing a unit test for AclEntry).

-Alan.