7020888: (file) Miscellaneous and trivial clean-ups (typos and opportunities to use suppressed exceptions)

Mike Duigou mike.duigou at oracle.com
Sun Feb 20 05:57:14 PST 2011


All look good to me. Catching Throwable in SocketChannel does looks a little suspiciously broad. Other non-IOExceptions thrown in the context of the sc.close() would cause the original x to be lost. One can imagine an OutOfMemoryError being thrown especially if x is also an OME.

Mike

On Feb 20 2011, at 02:33 , Alan Bateman wrote:

> 
> A small update to fix a few random typos in the javadoc and a broken link that slipped through. In addition it addresses (some) of the opportunities to record suppressed exceptions - these are places where try-with-resources isn't appropriate. The webrev with the changes is here:
> 
> http://cr.openjdk.java.net/~alanb/7020888/webrev/
> 
> Thanks,
> Alan.



More information about the nio-dev mailing list