Code review request: 7068616 NIO libraries do not build with javac -Xlint:all,-deprecation -Werror

Alexandre Boulgakov alexandre.boulgakov at oracle.com
Wed Jul 27 14:42:08 PDT 2011


Hello everyone,

Please review these NIO changes.
Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7068616 
<http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7068616>
webrev: http://cr.openjdk.java.net/~alanb/7068616/webrev/

Most of the changes are one-line fixes to remove warnings, and I've 
updated the make files to flag warnings as errors from now on, ignoring 
deprecation warnings in sun.io.*. I also revised some of the try-catch 
blocks to make use of multicatch syntax.

There are two larger changes in 
src/solaris/classes/sun/nio/ch/SctpChannelImpl.java and 
src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java, where I 
changed a private inner class from "private class 
InternalNotificationHandler<T> extends AbstractNotificationHandler<T>" 
to "private class InternalNotificationHandler extends 
AbstractNotificationHandler<Object>" because it was not using the type 
variable T. AbstractNotificationHandler<Object> is consistent with the 
original behavior where InternalNotificationHandler was used as a raw type.

Thanks,
Sasha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20110727/3f0c1341/attachment.html 


More information about the nio-dev mailing list