7052272: (aio) Definition of ConnectEx doesn't specify PASCAL calling convention

Chris Hegarty chris.hegarty at oracle.com
Fri Jun 17 00:50:33 PDT 2011


Look fine to me.

-Chris.

On 06/ 8/11 01:35 PM, Alan Bateman wrote:
>
> The asynchronous I/O implementation on Windows defines the ConnectEx
> extension without specifying the calling convention and so doesn't match
> the actual calling convention. This creates potential issues although we
> haven't had any reports. Easily fixed with the attached patch. This one
> is for jdk8 (too late for jdk7).
>
> -Alan
>
>
> diff --git
> a/src/windows/native/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.c
> b/src/windows/native/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.c
> --- a/src/windows/native/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.c
> +++ b/src/windows/native/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.c
> @@ -44,7 +44,7 @@
> #define SO_UPDATE_CONNECT_CONTEXT 0x7010
> #endif
>
> -typedef BOOL (*ConnectEx_t)
> +typedef BOOL (PASCAL *ConnectEx_t)
> (
> SOCKET s,
> const struct sockaddr* name,
>


More information about the nio-dev mailing list