From mike.duigou at oracle.com Tue May 3 17:07:24 2011 From: mike.duigou at oracle.com (Mike Duigou) Date: Tue, 3 May 2011 17:07:24 -0700 Subject: Review Request : 7041612 : Rename StandardCharset to StandardCharsets Message-ID: Hello All; Per the most recent message from Mark Reinhold (http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-May/006827.html) the recently added StandardCharset class will be renamed to StandardCharsets to better reflect that it is not an enum. We would like to get this change in ASAP. Webrev here: http://cr.openjdk.java.net/~mduigou/7041612/0/webrev/ Thanks, Mike From Alan.Bateman at oracle.com Wed May 4 06:15:48 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 04 May 2011 14:15:48 +0100 Subject: Review Request : 7041612 : Rename StandardCharset to StandardCharsets In-Reply-To: References: Message-ID: <4DC15184.4020904@oracle.com> Mike Duigou wrote: > Hello All; > > Per the most recent message from Mark Reinhold (http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-May/006827.html) the recently added StandardCharset class will be renamed to StandardCharsets to better reflect that it is not an enum. > > We would like to get this change in ASAP. > > Webrev here: http://cr.openjdk.java.net/~mduigou/7041612/0/webrev/ > > Thanks, > > Mike The s/StandardCharset/StandardCharsets/g changes look okay to me. As I mentioned off-list, I wonder if we should re-examine StandardSocketOption and StandardWatchEventKind too. -Alan. From Lance.Andersen at oracle.com Wed May 4 05:50:12 2011 From: Lance.Andersen at oracle.com (Lance Andersen - Oracle) Date: Wed, 4 May 2011 08:50:12 -0400 Subject: Review Request : 7041612 : Rename StandardCharset to StandardCharsets In-Reply-To: References: Message-ID: Looks good to me. Best, Lance On May 3, 2011, at 8:07 PM, Mike Duigou wrote: > Hello All; > > Per the most recent message from Mark Reinhold (http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-May/006827.html) the recently added StandardCharset class will be renamed to StandardCharsets to better reflect that it is not an enum. > > We would like to get this change in ASAP. > > Webrev here: http://cr.openjdk.java.net/~mduigou/7041612/0/webrev/ > > Thanks, > > Mike Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20110504/077f5178/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: oracle_sig_logo.gif Type: image/gif Size: 658 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20110504/077f5178/attachment.gif From Alan.Bateman at oracle.com Mon May 9 02:39:31 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 09 May 2011 10:39:31 +0100 Subject: 7042979: Rename StandardSocketOption and StandardWatchEventKind Message-ID: <4DC7B653.1070308@oracle.com> The recent discussion on whether the class defining the standard charsets be named StandardCharset or StandardCharsets raises the question for three other classes that are also new in jdk7: java.net.StandardSocketOption java.nio.file.StandardWatchEventKind com.sun.nio.sctp.SctpStandardSocketOption (part of the SCTP API) Given the decision to rename StandardCharset it would be inconsistent if we didn't rename these too. To that end, and disruptive as it might be, the webrev with the changes is here: http://cr.openjdk.java.net/~alanb/7042979/webrev/ Thanks, -Alan. From forax at univ-mlv.fr Mon May 9 03:09:19 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Mon, 09 May 2011 12:09:19 +0200 Subject: 7042979: Rename StandardSocketOption and StandardWatchEventKind In-Reply-To: <4DC7B653.1070308@oracle.com> References: <4DC7B653.1070308@oracle.com> Message-ID: <4DC7BD4F.3020800@univ-mlv.fr> On 05/09/2011 11:39 AM, Alan Bateman wrote: > > The recent discussion on whether the class defining the standard > charsets be named StandardCharset or StandardCharsets raises the > question for three other classes that are also new in jdk7: > > java.net.StandardSocketOption > java.nio.file.StandardWatchEventKind > com.sun.nio.sctp.SctpStandardSocketOption (part of the SCTP API) > > Given the decision to rename StandardCharset it would be inconsistent > if we didn't rename these too. To that end, and disruptive as it might > be, the webrev with the changes is here: > http://cr.openjdk.java.net/~alanb/7042979/webrev/ > > Thanks, > > -Alan. > Hi Alan, It's ok for me. I see that you have changed the context's type of StandardWatcheventKinds.OVERFLOW from Void to Object to allow implementation specific context. Am I right ? R?mi From Alan.Bateman at oracle.com Mon May 9 04:32:39 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 09 May 2011 12:32:39 +0100 Subject: 7042979: Rename StandardSocketOption and StandardWatchEventKind In-Reply-To: <4DC7BD4F.3020800@univ-mlv.fr> References: <4DC7B653.1070308@oracle.com> <4DC7BD4F.3020800@univ-mlv.fr> Message-ID: <4DC7D0D7.40605@oracle.com> R?mi Forax wrote: > > Hi Alan, > It's ok for me. > > I see that you have changed the context's type of > StandardWatcheventKinds.OVERFLOW > from Void to Object to allow implementation specific context. Am I > right ? Ah yes, I should have mentioned that one. It might be useful for the OVERFLOW event to carry some context so it would be better if the type parameter weren't Void. -Alan From chris.hegarty at oracle.com Mon May 9 05:42:59 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 09 May 2011 13:42:59 +0100 Subject: 7042979: Rename StandardSocketOption and StandardWatchEventKind In-Reply-To: <4DC7B653.1070308@oracle.com> References: <4DC7B653.1070308@oracle.com> Message-ID: <4DC7E153.7070003@oracle.com> I've take a look at the SCTP changes ( as well as the others ). Looks fine to me. -Chris. On 05/ 9/11 10:39 AM, Alan Bateman wrote: > > The recent discussion on whether the class defining the standard > charsets be named StandardCharset or StandardCharsets raises the > question for three other classes that are also new in jdk7: > > java.net.StandardSocketOption > java.nio.file.StandardWatchEventKind > com.sun.nio.sctp.SctpStandardSocketOption (part of the SCTP API) > > Given the decision to rename StandardCharset it would be inconsistent if > we didn't rename these too. To that end, and disruptive as it might be, > the webrev with the changes is here: > http://cr.openjdk.java.net/~alanb/7042979/webrev/ > > Thanks, > > -Alan. > From martijnverburg at gmail.com Mon May 9 06:39:40 2011 From: martijnverburg at gmail.com (Martijn Verburg) Date: Mon, 9 May 2011 15:39:40 +0200 Subject: 7042979: Rename StandardSocketOption and StandardWatchEventKind In-Reply-To: <4DC7E153.7070003@oracle.com> References: <4DC7B653.1070308@oracle.com> <4DC7E153.7070003@oracle.com> Message-ID: Looks good to me as well. On 9 May 2011 14:42, Chris Hegarty wrote: > I've take a look at the SCTP changes ( as well as the others ). Looks fine > to me. > > -Chris. > > On 05/ 9/11 10:39 AM, Alan Bateman wrote: >> >> The recent discussion on whether the class defining the standard >> charsets be named StandardCharset or StandardCharsets raises the >> question for three other classes that are also new in jdk7: >> >> java.net.StandardSocketOption >> java.nio.file.StandardWatchEventKind >> com.sun.nio.sctp.SctpStandardSocketOption (part of the SCTP API) >> >> Given the decision to rename StandardCharset it would be inconsistent if >> we didn't rename these too. To that end, and disruptive as it might be, >> the webrev with the changes is here: >> http://cr.openjdk.java.net/~alanb/7042979/webrev/ >> >> Thanks, >> >> -Alan. >> > From Alan.Bateman at oracle.com Tue May 10 10:12:59 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 10 May 2011 18:12:59 +0100 Subject: 7043425: (fc) ClosedByInterruptException thrown but interrupt status not set Message-ID: <4DC9721B.4090803@oracle.com> Here's an embarrassing one. If a thread closing a FileChannel is interrupted while it is waiting for other threads to complete their I/O operations then the interrupt status is not reset. The JavaDB/Derby folks ran into this while testing with jdk7-b141. Thanks for David Holmes for spotting the bug. The webrev with the fix is here: http://cr.openjdk.java.net/~alanb/7043425/webrev/ Thanks, Alan. From Alan.Bateman at oracle.com Wed May 11 04:33:53 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 11 May 2011 12:33:53 +0100 Subject: 7043788: (fs) PosixFileAttributes.owner() or group() throws NPE if not group in passwd/group database Message-ID: <4DCA7421.1050106@oracle.com> This is another little embarrassing one. A test that reads the PosixFileAttributes and prints out the owner and group-owner fails with NPE if the the lookup of the uid or gid fails because it's not in the passwd or group database. It turns out that the "not found" handling in the native code isn't correct with the result that it returns null for these cases instead of failing. The webrev with the changes is here: http://cr.openjdk.java.net/~alanb/7043788/webrev/ I've decided not to include a test for this because it requires privileges to chown or chgrp a file to some unknown uid/gid. Thanks, -Alan From chris.hegarty at oracle.com Wed May 11 06:25:49 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 11 May 2011 14:25:49 +0100 Subject: 7043788: (fs) PosixFileAttributes.owner() or group() throws NPE if not group in passwd/group database In-Reply-To: <4DCA7421.1050106@oracle.com> References: <4DCA7421.1050106@oracle.com> Message-ID: <4DCA8E5D.4090201@oracle.com> Looks fine to me. -Chris. On 05/11/11 12:33 PM, Alan Bateman wrote: > > This is another little embarrassing one. A test that reads the > PosixFileAttributes and prints out the owner and group-owner fails with > NPE if the the lookup of the uid or gid fails because it's not in the > passwd or group database. It turns out that the "not found" handling in > the native code isn't correct with the result that it returns null for > these cases instead of failing. The webrev with the changes is here: > > http://cr.openjdk.java.net/~alanb/7043788/webrev/ > > I've decided not to include a test for this because it requires > privileges to chown or chgrp a file to some unknown uid/gid. > > Thanks, > > -Alan From chris.hegarty at oracle.com Wed May 11 06:39:38 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 11 May 2011 14:39:38 +0100 Subject: 7043425: (fc) ClosedByInterruptException thrown but interrupt status not set In-Reply-To: <4DC9721B.4090803@oracle.com> References: <4DC9721B.4090803@oracle.com> Message-ID: <4DCA919A.4020505@oracle.com> What you have done here looks fine to me, but I wonder if we should break out of the loop in signaAndWait if interrupted? -Chris. On 05/10/11 06:12 PM, Alan Bateman wrote: > > Here's an embarrassing one. If a thread closing a FileChannel is > interrupted while it is waiting for other threads to complete their I/O > operations then the interrupt status is not reset. The JavaDB/Derby > folks ran into this while testing with jdk7-b141. Thanks for David > Holmes for spotting the bug. The webrev with the fix is here: > > http://cr.openjdk.java.net/~alanb/7043425/webrev/ > > Thanks, > Alan. From Alan.Bateman at oracle.com Wed May 11 06:51:07 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 11 May 2011 14:51:07 +0100 Subject: 7043425: (fc) ClosedByInterruptException thrown but interrupt status not set In-Reply-To: <4DCA919A.4020505@oracle.com> References: <4DC9721B.4090803@oracle.com> <4DCA919A.4020505@oracle.com> Message-ID: <4DCA944B.8050708@oracle.com> Chris Hegarty wrote: > What you have done here looks fine to me, but I wonder if we should > break out of the loop in signaAndWait if interrupted? > > -Chris. > Thanks for looking at it. We can't break out of the loop. This is part of the asynchronous close. N threads are doing I/O on the file. We use our dup2 trick to close the file and signal the threads so that complete the I/O operations quickly. This loop is just waiting until all the I/O operations have been completed so that the close can continue and release the file descriptor. -Alan From chris.hegarty at oracle.com Wed May 11 06:48:51 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 11 May 2011 14:48:51 +0100 Subject: 7043425: (fc) ClosedByInterruptException thrown but interrupt status not set In-Reply-To: <4DCA944B.8050708@oracle.com> References: <4DC9721B.4090803@oracle.com> <4DCA919A.4020505@oracle.com> <4DCA944B.8050708@oracle.com> Message-ID: <4DCA93C3.90801@oracle.com> OK, thanks for the explanation. I'm ok with it as is. -Chris. On 05/11/11 02:51 PM, Alan Bateman wrote: > Chris Hegarty wrote: >> What you have done here looks fine to me, but I wonder if we should >> break out of the loop in signaAndWait if interrupted? >> >> -Chris. >> > Thanks for looking at it. We can't break out of the loop. This is part > of the asynchronous close. N threads are doing I/O on the file. We use > our dup2 trick to close the file and signal the threads so that complete > the I/O operations quickly. This loop is just waiting until all the I/O > operations have been completed so that the close can continue and > release the file descriptor. > > -Alan From forax at univ-mlv.fr Wed May 11 07:07:07 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Wed, 11 May 2011 16:07:07 +0200 Subject: 7043425: (fc) ClosedByInterruptException thrown but interrupt status not set In-Reply-To: <4DCA93C3.90801@oracle.com> References: <4DC9721B.4090803@oracle.com> <4DCA919A.4020505@oracle.com> <4DCA944B.8050708@oracle.com> <4DCA93C3.90801@oracle.com> Message-ID: <4DCA980B.1050007@univ-mlv.fr> Looks fine for me too. R?mi On 05/11/2011 03:48 PM, Chris Hegarty wrote: > OK, thanks for the explanation. I'm ok with it as is. > > -Chris. > > On 05/11/11 02:51 PM, Alan Bateman wrote: >> Chris Hegarty wrote: >>> What you have done here looks fine to me, but I wonder if we should >>> break out of the loop in signaAndWait if interrupted? >>> >>> -Chris. >>> >> Thanks for looking at it. We can't break out of the loop. This is part >> of the asynchronous close. N threads are doing I/O on the file. We use >> our dup2 trick to close the file and signal the threads so that complete >> the I/O operations quickly. This loop is just waiting until all the I/O >> operations have been completed so that the close can continue and >> release the file descriptor. >> >> -Alan From Alan.Bateman at oracle.com Wed May 11 07:30:46 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 11 May 2011 15:30:46 +0100 Subject: 7043425: (fc) ClosedByInterruptException thrown but interrupt status not set In-Reply-To: <4DCA980B.1050007@univ-mlv.fr> References: <4DC9721B.4090803@oracle.com> <4DCA919A.4020505@oracle.com> <4DCA944B.8050708@oracle.com> <4DCA93C3.90801@oracle.com> <4DCA980B.1050007@univ-mlv.fr> Message-ID: <4DCA9D96.3050302@oracle.com> R?mi Forax wrote: > Looks fine for me too. > > R?mi > Thanks R?mi. Unfortunately I pushed it to the TL forest before seeing your mail so I didn't get to list you as a reviewer. -Alan. From forax at univ-mlv.fr Wed May 11 07:32:22 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Wed, 11 May 2011 16:32:22 +0200 Subject: 7043425: (fc) ClosedByInterruptException thrown but interrupt status not set In-Reply-To: <4DCA9D96.3050302@oracle.com> References: <4DC9721B.4090803@oracle.com> <4DCA919A.4020505@oracle.com> <4DCA944B.8050708@oracle.com> <4DCA93C3.90801@oracle.com> <4DCA980B.1050007@univ-mlv.fr> <4DCA9D96.3050302@oracle.com> Message-ID: <4DCA9DF6.8030400@univ-mlv.fr> On 05/11/2011 04:30 PM, Alan Bateman wrote: > R?mi Forax wrote: >> Looks fine for me too. >> >> R?mi >> > Thanks R?mi. Unfortunately I pushed it to the TL forest before seeing > your mail so I didn't get to list you as a reviewer. > > -Alan. No problem. More reviewers are better than less. R?mi From crodster2k at yahoo.com Thu May 26 01:47:35 2011 From: crodster2k at yahoo.com (Rob Butler) Date: Thu, 26 May 2011 01:47:35 -0700 (PDT) Subject: Message-ID: <888416.61532.qm@web120501.mail.ne1.yahoo.com> Are you capable of having sex non-stop?. http://www.clubmedian.hu/friends_links.php?tjxpage=20i6 From Alan.Bateman at oracle.com Thu May 26 02:05:56 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 26 May 2011 10:05:56 +0100 Subject: spam Message-ID: <4DDE17F4.60505@oracle.com> Apologies that spam got through on this list today. It looks like someone subscribed to this list has been compromised. I have used moderator privileges to unsubscribe them. -Alan