7042979: Rename StandardSocketOption and StandardWatchEventKind

Martijn Verburg martijnverburg at gmail.com
Mon May 9 06:39:40 PDT 2011


Looks good to me as well.

On 9 May 2011 14:42, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> I've take a look at the SCTP changes ( as well as the others ). Looks fine
> to me.
>
> -Chris.
>
> On 05/ 9/11 10:39 AM, Alan Bateman wrote:
>>
>> The recent discussion on whether the class defining the standard
>> charsets be named StandardCharset or StandardCharsets raises the
>> question for three other classes that are also new in jdk7:
>>
>> java.net.StandardSocketOption
>> java.nio.file.StandardWatchEventKind
>> com.sun.nio.sctp.SctpStandardSocketOption (part of the SCTP API)
>>
>> Given the decision to rename StandardCharset it would be inconsistent if
>> we didn't rename these too. To that end, and disruptive as it might be,
>> the webrev with the changes is here:
>> http://cr.openjdk.java.net/~alanb/7042979/webrev/
>>
>> Thanks,
>>
>> -Alan.
>>
>


More information about the nio-dev mailing list