Fwd: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor
Alan Bateman
Alan.Bateman at oracle.com
Sat Nov 19 11:44:56 PST 2011
On 18/11/2011 10:57, Chris Hegarty wrote:
> Hi Kris,
>
> I think this change should be fine, but I would like Alan to comment also.
>
I looked at it in more detail and I think it should okay. Will you
sponsor it? My only comment on the change is the catching of
SocketException causes a RuntimeException to be thrown but that is
inconsistent with other areas of this code where AssertionError or
InternalError is thrown.
-Alan
More information about the nio-dev
mailing list