7091935: (fs) Polling based WatchService not used on Linux

[Salter, Thomas A]

Will it still be compiled at all, by Oracle builds?  We're currently using it as a stop-gap solution until we can do a better performing implementation.  I worry about the code continuing to compile cleanly (not to mention working) if it's not being compiled in the standard builds.

Tom Salter


-----Original Message-----
From: nio-dev-bounces at openjdk.java.net [mailto:nio-dev-bounces at openjdk.java.net] On Behalf Of Alan Bateman
Sent: Sunday, September 18, 2011 4:26 AM
To: nio-dev
Subject: 7091935: (fs) Polling based WatchService not used on Linux


As folks will recall, we have 4 implementations of WatchService, one 
each for Solaris, Linux, and Windows and then a poor performing but 
portable implementation that polls the file system. Currently on Linux 
we build both the inotify and polling implementation but the polling 
implementation is never used at runtime. The attached patch just removes 
it from the make file so that it is no longer included on this platform.

Thanks,
Alan.

diff --git a/make/java/nio/Makefile b/make/java/nio/Makefile
--- a/make/java/nio/Makefile
+++ b/make/java/nio/Makefile
@@ -206,7 +206,6 @@ FILES_java += \
        sun/nio/fs/LinuxUserDefinedFileAttributeView.java \
        sun/nio/fs/LinuxNativeDispatcher.java \
        sun/nio/fs/LinuxWatchService.java \
-       sun/nio/fs/PollingWatchService.java \
        sun/nio/fs/UnixChannelFactory.java \
        sun/nio/fs/UnixCopyFile.java \
        sun/nio/fs/UnixDirectoryStream.java \