Code review request 7189886: improve AsynchronousChannelGroup tests to cover withThreadPool method

[Amy Lu]

Thank you Alan !

Thanks,
Amy

On 8/8/12 9:28 PM, Alan Bateman wrote:
> On 08/08/2012 12:25, Amy Lu wrote:
>>
>> While going through the missing coverage APIs, withThreadPool method 
>> of AsynchronousChannelGroup is not covered by any test.
>> This is improvement for AsynchronousChannelGroup tests to cover this 
>> method.
>>
>> Thanks Alan for help posting the webrev. Please review:
>> http://cr.openjdk.java.net/~alanb/7189886/webrev.00/
>>
>> Thanks,
>> Amy
>>
> Thanks Amy, it's good to add coverage for this method.
>
> The changes mostly look good. The only thing is the 
> Executors.newFixedThreadPool(rand.nextInt(5),factory) in Restart.java 
> where it might be possible for nextInt to return 0 and so 
> newFixedThreadPool will fail. I can fix this before pushing the change 
> for you.
>
> -Alan.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20120809/06575096/attachment.html