Code review request 7132889: Possible race conditions in AbstractSelectableChannel

Alan Bateman Alan.Bateman at oracle.com
Mon Aug 13 08:23:42 PDT 2012


On 13/08/2012 14:01, Alan Bateman wrote:
> On 08/08/2012 13:40, Shirish Kuncolienkar wrote:
>>
>> I agree that the specification change is not necessary. The change in 
>> implCloseChannel could be limited to eliminating the possibility of 
>> getting a valid selection key while the channel is being closed.
>> -Shirish
>>
> I think the remaining changes are correct. Can you re-generate the 
> webrev so that we have the final patch and I will sponsor this one?
On second thoughts, as the regLock is the blockingLock then I don't 
think it can be acquired by implCloseChannel so the change will need to 
limited to register and configure. One thing that would be good to do is 
to run the tests (in test/java/nio/channels) with your changes to make 
sure that there aren't any issues.

-Alan.


More information about the nio-dev mailing list