Code review request 7132889: Possible race conditions in AbstractSelectableChannel

[Alan Bateman]

On 20/08/2012 15:20, Shirish Kuncolienkar wrote:
>
> Alan,
>
> I created a new patch http://cr.openjdk.java.net/~luchsh/webrev.000/ 
> based on your suggestions and tested the same against 
> java/nio/channels tests
>
> I see no new failures as compared to
> java version "1.8.0-ea"
> Java(TM) SE Runtime Environment (build 1.8.0-ea-b49)
> Java HotSpot(TM) 64-Bit Server VM (build 24.0-b16, mixed mode)
>
> Detailed Test results
> passed: 159; failed: 1; error: 1
> Error:  java/nio/channels/DatagramChannel/AdaptDatagramSocket.java
> FAILED: java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java
>
> The timing window was seen during fixing of the select loop issue and 
> the changes are being held as a patch.
Formatting aside, the updated patch looks good. I will sponsor this patch.

On the tests then I'm not sure why MulticastSendReceiveTests.java is 
failing for you. Can you forward the .jtr (output) file? It it possible 
that firewall or VPN settings are causing muticast packets to be dropped?

-Alan.