Review Request - JDK-7194370 (fs) WatchService fails if volume S/N is 0 [win]

Alan Bateman Alan.Bateman at oracle.com
Sat Dec 8 02:29:01 PST 2012


On 08/12/2012 00:03, Dan Xu wrote:
> Hi folks,
>
> Please help review the fix for JDK-7194370,,(fs) WatchService fails if 
> volume S/N is 0 [win]. The webrev is uploaded at, 
> http://cr.openjdk.java.net/~dxu/7194370/webrev/.
>
> The issue is because we have an assumption that volumn serial number 
> cannot be 0.The serial number is 32-bit number determined by the date 
> on the currentcomputer at the time of a disk's formatting. It is very 
> rare for a volumnto be assigned a serial number as 0000-0000. But it 
> could happen. The fix is to remove non-zero assertions.Thanks!
>
> -Dan
Thanks Dan, an oversight in the original implementation. I'll push this 
for you.

-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20121208/438ff4ec/attachment.html 


More information about the nio-dev mailing list