review request: 7114611 -- (fs) DirectoryStream fails with SIGBUS on some embedded platforms, dirent alignment

David Holmes david.holmes at oracle.com
Wed Feb 8 20:17:55 PST 2012


On 9/02/2012 8:53 AM, Carlos Lucasius wrote:
> http://cr.openjdk.java.net/~clucasius/7114611/webrev.03/

Looks fine to me.

For the benefit of readers, the use of PATH_MAX may be excessive but it 
is no worse than what we do today. Unfortunately NAME_MAX is not 
guaranteed to be a compile-time constant (and isn't on Solaris) and 
using fpathconf to look it up introduces its own secondary problems (eg 
error handling).

David
-----

> Thanks,
>
> /-/Carlos
>


More information about the nio-dev mailing list