Please review: Add EACCES check to the return value of fcntl()
Charles Lee
littlee at linux.vnet.ibm.com
Wed Feb 15 00:26:39 PST 2012
On 02/15/2012 04:06 PM, Alan Bateman wrote:
> On 15/02/2012 07:11, Charles Lee wrote:
>> Hi guys,
>>
>> Patch @ http://cr.openjdk.java.net/~littlee/OJDK-327/webrev.00/
>> <http://cr.openjdk.java.net/%7Elittlee/OJDK-327/webrev.00/>
>>
>> The patch is mainly about add the EACCES when check the errno of
>> fcntl with command F_SETLK.
>>
>> From the man page:
>> /If a conflicting lock is held by another process, this call returns
>> -1 and sets errno to EACCES or EAGAIN.
>>
>> /I propose to add the EACCES check. Would anyone help to review the
>> patch?
> Looks okay to me although I'm surprised we haven't run into this
> before (the file locking code is there since jdk1.4). Are you seeing
> this only on AIX or have you seen it on Linux/Solaris too?
>
> -Alan
Hi Alan,
It seems AIX has a special choice. :-)
--
Yours Charles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20120215/d2391bcb/attachment.html
More information about the nio-dev
mailing list