RFR: 7152948 msghdr structure not initialized properly in DatagramDispatcher

chris hegarty chris.hegarty at oracle.com
Mon Mar 12 14:05:06 PDT 2012


On 12/03/2012 10:42, Alan Bateman wrote:
> ...
> 7152948: (dc) DatagramDispatcher.c should memset msghdr to make it
> portable to other platforms
>
> The changes look okay to me but I think might be a bit cleaner to do the
> memset just prior to setting msg_iov/msg_iovlen (to keep the
> initialization of the msghdr structure in one place).
>
> While you are there, can you change the value 16 to IOV_MAX? (requires
> limits.h).

Yes, this would be better. I also agree with your previous comment.

I ran some builds and tests on Solaris and Linux with the current patch. 
All pass fine. I'll do the same when Shi Jun posts an updated patch.

-Chris.

>
> -Alan
>
>
>
>


More information about the nio-dev mailing list