Fwd: Remove including of link.h to improve portability

Jonathan Lu luchsh at linux.vnet.ibm.com
Thu Mar 15 19:18:36 PDT 2012


On 03/15/2012 10:42 PM, Chris Hegarty wrote:
> On 15/03/12 07:17, Jonathan Lu wrote:
>> On 03/13/2012 06:25 PM, Alan Bateman wrote:
>>> On 13/03/2012 10:21, Jonathan Lu wrote:
>>>> Hi Alan,
>>>>
>>>> With Phil's advice, I've splitted the original patch into two parts
>>>> and created another bug for TL repository, bug 7153343.
>>>>
>>>> And here's the rebased patch based on TL repository.
>>>> http://cr.openjdk.java.net/~luchsh/7153343/jdk.patch
>>>>
>>>> Could you please take a look?
>>> It looks okay to me.
>>>
>>> -Alan
>> Thanks Alan!
>>
>> Can anybody else please help to take a look at the patch?
>
> The source changes look fine. I ran some fresh builds and tests, all 
> pass fine and no (new) warnings.
>
> I see you are an author for jdk8. Will Charles be pushing this for 
> you, or do you want me too?
>
> -Chris.
>
>>
>> Regards
>> - Jonathan Lu
Hi Chris,

Thanks for review, I'll ask Charles to help to push the change.

Regards
- Jonathan



More information about the nio-dev mailing list