Code Review Request: 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking

[Kurchi Subhra Hazra]

Looking back now and as rightly pointed out by you, all that we need to 
change to fix this issue is:
http://cr.openjdk.java.net/~khazra/7096436/webrev.02/

Thanks,
Kurchi

On 5/7/12 12:25 PM, Kurchi Hazra wrote:
> I see. Updated webrev:
>
> http://cr.openjdk.java.net/~khazra/7096436/webrev.01/
>
>
>
> Thanks,
> Kurchi
>
> On 5/7/2012 10:11 AM, Alan Bateman wrote:
>> On 07/05/2012 17:02, Kurchi Subhra Hazra wrote:
>>>
>>> In this case what happens if someone calls:
>>> sc.socket.bind(address);
>>> sc.getLocalAddress();
>>>
>>> I am guessing that state will still be ST_UNCONNECTED, and 
>>> getLocalAddress will return null. Or am I missing something?
>> The bind method will set localAddress after binding the socket and 
>> shouldn't need to change. It's possible that after the connection is 
>> established that the local address will be some specific that the 
>> address that we explicitly bound to, in which case the logic to set 
>> localAddress when changing the state to ST_CONNECTED will handle this.
>>
>> -Alan
>
> -- 
> -Kurchi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20120507/75c0e826/attachment.html